Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Created by
brew bumpCreated with
brew bump-formula-pr.release notes
The stored procedures rewrite fixed an issue where temporary tables aren't able to be created and selected within a stored procedure; this PR adds tests to specifically test for that case.
fixes: Stored procedure: temp table created in procedure not visible dolthub/dolt#8762
Fix #9130 and #9069.
Similar to Consistently use pointer receivers for TextStorage methods. dolthub/dolt#9100
For structs that are exclusively used in interfaces, there's no reason to not use pointer receivers instead of value receivers. Using value receivers can cause the struct to be copied every time the method is invoked.
Pointer receivers are also more correct here: copying the struct means that changes to the ImmutableValue field (such as setting its Buf field in ImmutableValue.GetBytes) won't be saved when the method exits, defeating the caching of values loaded from storage.
go-mysql-server
These are a couple more functions whose inputs aren't being unwrapped. If the inputs come from a column with a
TEXTtype, then they won't be converted to strings and the functions will fail. This PR fixes this by making sure that the inputs are converted.We missed this previously because although we have tests for these functions, none of them tested getting the inputs from TEXT columns of a table.
Merged main from Support format parameter and timezone in
from_unixtimedolthub/go-mysql-server#2910fixes: Stored procedures: stored procedure with recursive call does not terminate dolthub/dolt#8763
This PR adds tests for user variables within Stored Procedures.
Additionally, this PR has changes so that we don't double parse
PREPARE ... FROM ...statements, which also allows them to be used in the updated Stored Procedures call.fixes: can't assign local variables to user variables dolthub/dolt#8911
This makes literal expression implement the sqlparser.Injectable interface so they can be used in Doltgres AST conversion.
Also exports fields so literals can be edited in place (required for how Doltgres processes these in a couple places).
This is an alternative to Introduced a sql.LiteralExpression, and used it in most places dolthub/go-mysql-server#2946.
UPDATE ... RETURNINGRelated to:
UPDATE...RETURNINGnot yet supported dolthub/doltgresql#1421This PR reimplements Stored Procedures so that queries are run individually, while maintaining context through the use of a stack.
companion pr: add variable to colval dolthub/vitess#402
vitess
RETURNINGtoUPDATEandINSERTnodesClosed Issues
statusis run after deleting theoriginremote.